On Fri, 16 Oct 2020 01:40:48 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Weijun Wang has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental >> views will show differences compared to the previous content of the PR. > > test/jdk/jdk/security/jarsigner/Spec.java line 128: > >> 126: npe(()->b1.setProperty("sectionsonly", null)); >> 127: iae(()->b1.setProperty("sectionsonly", "OK")); >> 128: npe(()->b1.setProperty("sectionsonly", null)); > > Is 'altsigner' support removed? But I saw it being used in later part of this > test. The javadoc for JarSigner.Builder > only lists a subset of above properties. Are those not in javadoc internal > and can be removed any time, just curious? > Nit: maybe add 8242068 to `@bug line` for existing regression tests? It's deprecated. I remember we are already thinking about deprecating the altSign mechanism when creating the JarSigner API and therefore we didn't add them to the spec from the beginning. Bug id added. ------------- PR: https://git.openjdk.java.net/jdk/pull/322