On Fri, 21 May 2021 15:37:48 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> typo on windows
>
> src/java.base/share/classes/sun/net/ftp/impl/FtpClient.java line 550:
>
>> 548: * @throws IOException if the connection was unsuccessful.
>> 549: */
>> 550: @SuppressWarnings("removal")
>
> Could the scope of the annotation be further reduced by applying it to the
> two places where `doPrivileged` is called in this method?
I'll probably need to assign the doPriv result on L631 to a tmp variable and
then assign it to `s`. Are you OK with this ugliness? Update: Ah, I see you
already have similar suggestion in the next comment.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4138
