On Fri, 6 Aug 2021 19:16:39 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Smita Kamath has updated the pull request incrementally with five additional >> commits since the last revision: >> >> - Merge branch 'aes-gcm' of github.com:smita-kamath/jdk into aes-gcm >> - Updates, comment and variable cleanup >> - merge rest >> - merge >> - fixes and code comments > > src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java > line 1779: > >> 1777: int len = 0; >> 1778: if (inLen >= PARALLEL_LEN) { >> 1779: implGCMCrypt(in, inOfs, inLen, in, inOfs, out, outOfs, >> gctr, > > Should save the return value into 'len'? For consistency sake, choose between > GaloisCounterMode.implGCMCrypt(...) and implGCMCrypt and not both? I do not understand this comment ------------- PR: https://git.openjdk.java.net/jdk/pull/4019