On Fri, 6 Aug 2021 19:32:25 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Smita Kamath has updated the pull request incrementally with five additional >> commits since the last revision: >> >> - Merge branch 'aes-gcm' of github.com:smita-kamath/jdk into aes-gcm >> - Updates, comment and variable cleanup >> - merge rest >> - merge >> - fixes and code comments > > src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java > line 1648: > >> 1646: >> 1647: ghash.doFinal(in, inOfs, inLen); >> 1648: return len + gctr.doFinal(in, inOfs, inLen, out, outOfs); > > Why not just keep "return len + op.doFinal(in, inOfs, inLen, out, outOfs);"? It probably got changed because I was cleaning up unused 'op' elsewhere ------------- PR: https://git.openjdk.java.net/jdk/pull/4019