On Tue, 9 May 2023 14:26:46 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> src/java.base/share/classes/sun/security/provider/HSS.java line 661:
>>
>>> 659:
>>> 660: @SuppressWarnings("deprecation")
>>> 661: HSSPublicKey(byte[] keyArray) throws InvalidKeyException {
>>
>> [I deleted my earlier comment]
>>
>> I am wondering why you don't call `super()` or `decode()` and override
>> `parseKeyBits()` like other `X509Key` subclasses.
>>
>> You should also override `writeReplace` so that serialization uses an
>> alternate form when serializing.
>>
>> It would probably be useful to override `toString()` as well. See other
>> `X509Key` subclasses for more details.
>
> Yes, I also think with `writeReplace` you can make `L` and `lmsPublicKey`
> transient and there is no need to make `LMSPublicKey` serializable.
`L` should be `transient` too as @wangweij noted.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13691#discussion_r1191465361
