On Mon, 4 Dec 2023 15:03:03 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> Matthew Donovan has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits since the last revision:
>>
>> - cleaned up MultipleLogins.java a little and added copyright date
>> - Merge branch 'master' into pkcs11-ol79
>> - Merge branch 'master' into pkcs11-ol79
>> - 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64
>
> test/jdk/sun/security/pkcs11/PKCS11Test.java line 766:
>
>> 764: }
>> 765:
>> 766: private static boolean isOracleLinux7() {
>
> Why not move that into some central place, e.g. test/lib/Platform.java ?
That's a good idea; I moved the method to the Platform class.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16547#discussion_r1428075259
