On Tue, 4 Jun 2024 02:32:31 GMT, Mark Powers <mpow...@openjdk.org> wrote:
> https://bugs.openjdk.org/browse/JDK-8333364 src/java.base/share/classes/com/sun/crypto/provider/RC2Parameters.java line 224: > 222: > 223: if (version != 0) { > 224: > sb.append(LINE_SEP).append("version:").append(LINE_SEP).append(version).append(LINE_SEP); Well, the original code is easier to read. Probably no difference performance-wise given it's just a few known strings. Why bother especially when the StringBuilder constructor also uses `+`? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19535#discussion_r1635444027
