On Tue, 4 Jun 2024 02:32:31 GMT, Mark Powers <mpow...@openjdk.org> wrote:
> https://bugs.openjdk.org/browse/JDK-8333364 src/java.base/share/classes/com/sun/crypto/provider/PBES2Parameters.java line 214: > 212: { > 213: String kdfAlgo; > 214: String cipherAlgo; nit: merge these with where they are assigned? src/java.base/share/classes/com/sun/crypto/provider/PBES2Parameters.java line 243: > 241: > 242: this.pbes2AlgorithmName = "PBEWith" + > 243: kdfAlgo + "And" + cipherAlgo; nit: move to one line if less than 80 chars. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19535#discussion_r1635455564 PR Review Comment: https://git.openjdk.org/jdk/pull/19535#discussion_r1635453641