On Fri, 17 Oct 2025 22:39:49 GMT, Mikhail Yankelevich 
<[email protected]> wrote:

>> In [JDK-8309667](https://bugs.openjdk.org/browse/JDK-8309667), there were 
>> issues with debugging due to no logging or throwing of errors by 
>> X509KeyManagerImpl::getEntry. 
>> [Line](https://github.com/openjdk/jdk/blob/6a4c2676a6378f573bd58d1bc32b57765d756291/src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java#L243-L245)
>> 
>> Extra logging and error propagating should be implemented for the 
>> X509KeyManagerImpl.
>> 
>> Additionally, dot checking logic has been changed, so no cases similar to 
>> `.A` will not trigger StringOutOfBounds exceptions. 
>> 
>> Thank you @djelinski for finding the issue and analysis.
>
> Mikhail Yankelevich has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Artur's comments

test/jdk/sun/security/ssl/X509KeyManager/X509KeyManagerNegativeTests.java line 
87:

> 85:     public static class MyCustomKSProvider extends java.security.Provider 
> {
> 86:         public MyCustomKSProvider() {
> 87:             super("MyCustomKSProvider", 1.0, "My Custom KS Provider");

Deprecated constructor.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27851#discussion_r2445300477

Reply via email to