On Tue, 2 Dec 2025 09:47:21 GMT, Jaikiran Pai <[email protected]> wrote:

>> test/jdk/javax/net/ssl/HttpsURLConnection/SubjectAltNameIPv6.java line 28:
>> 
>>> 26:  * @bug 8369950
>>> 27:  * @library /test/lib
>>> 28:  * @summary TLS connection to IPv6 address fails with BCJSSE due to 
>>> IllegalArgumentException
>> 
>> Nit - as per the jtreg tag order recommendation, the `@summary` should come 
>> before the `@library` https://openjdk.org/jtreg/tag-spec.html#ORDER
>
> Also, this test doesn't exercise the BouncyCastle provider. Would it be 
> better to change this line to say:
> 
> 
> @summary Test that the HttpsURLConnection does not set IPv6 address literals 
> for SNI hostname during TLS handshake

> Nit - as per the jtreg tag order recommendation, the `@summary` should come 
> before the `@library` https://openjdk.org/jtreg/tag-spec.html#ORDER

Thanks @jaikiran , i will update the order and the summary text. The 
BouncyCastle came here from the title of the issue.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28577#discussion_r2580611708

Reply via email to