On Thu, 5 Feb 2026 19:01:50 GMT, Weijun Wang <[email protected]> wrote:
>> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> patter matching comment > > src/java.base/share/classes/com/sun/crypto/provider/JceKeyStore.java line 640: > >> 638: dos.writeLong( >> 639: >> ((TrustedCertEntry)entry).date.toEpochMilli() >> 640: ); > > Not very common to write `);` on a new line. > > Same below on line 659. Also in `JavaKeyStore` line 633. I'd personally prefer to keep it this way as when it was inline it was really hard to read for me. If you feel strongly about it - I can change it :) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29140#discussion_r2770789150
