On Thu, 5 Feb 2026 19:27:33 GMT, Mikhail Yankelevich <[email protected]>
wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/JceKeyStore.java line
>> 640:
>>
>>> 638: dos.writeLong(
>>> 639:
>>> ((TrustedCertEntry)entry).date.toEpochMilli()
>>> 640: );
>>
>> Not very common to write `);` on a new line.
>>
>> Same below on line 659. Also in `JavaKeyStore` line 633.
>
> I'd personally prefer to keep it this way as when it was inline it was really
> hard to read for me. If you feel strongly about it - I can change it :)
No problem. In fact, I see on line 2440 of `PKCS12KeyStore` you have
instant = Instant.ofEpochMilli(
Long.parseLong(keyIdStr.substring(5)));
So I thought you're OK to either style.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29140#discussion_r2771228250
