On Thu, 12 Mar 2026 21:21:57 GMT, Weijun Wang <[email protected]> wrote:

>> This way it tests that `decodeUTCInstant` and `decodeUTC` are returning 
>> equivalent results. Just in case that there is a difference in nanos in the 
>> future in `byte[] b` as `Date` supports up to millis
>
> Not worth anticipating that. If it really happens, maybe we have a bug 
> somewhere.

But it also covers the new internal Instant methods and will flag if there are 
any broken changes in either `TimeParsing`, `DerValue` or `DerInputStream`. I'm 
not sure if leaving the methods uncovered is a good idea. 
If these methods will end up being completely removed in the future - this 
check could be removed as well. But since this is not happening right now I'd 
personally prefer to keep it

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30047#discussion_r2930277148

Reply via email to