On Fri, 13 Mar 2026 13:32:17 GMT, Weijun Wang <[email protected]> wrote:
>> But it also covers the new internal Instant methods and will flag if there >> are any broken changes in either `TimeParsing`, `DerValue` or >> `DerInputStream`. I'm not sure if leaving the methods uncovered is a good >> idea. >> If these methods will end up being completely removed in the future - this >> check could be removed as well. But since this is not happening right now >> I'd personally prefer to keep it > > I mean we just check `!d0.equals(d1)` and ignore the millisecond check. This > makes the test more sensitive and could reveal a bug in the future. Aaaah, yes this makes sense. Sorry, misunderstood you. Will fix in the next commit ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30047#discussion_r2931237835
