On Wed, 15 Apr 2026 19:54:28 GMT, Artur Barashev <[email protected]> wrote:

> SunJSSE implementation of `SSLEngine` throws an exception if being used 
> before calling `setUseClientMode()`. Javadoc wording in `SSLContextSpi` and 
> `SSLContext` classes should be improved.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

LGTM.

src/java.base/share/classes/javax/net/ssl/SSLContext.java line 354:

> 352:      *
> 353:      * @implNote
> 354:      * It is provider-specific if the returned SSLEngine uses client or

I think I'd keep the "It is provider-specific" sentence, though I'm not sure if 
it belongs in the implNote.

-------------

Marked as reviewed by djelinski (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/30754#pullrequestreview-4118895881
PR Review Comment: https://git.openjdk.org/jdk/pull/30754#discussion_r3091334086

Reply via email to