On Thu, 16 Apr 2026 12:40:15 GMT, Sean Mullan <[email protected]> wrote:

>> src/java.base/share/classes/javax/net/ssl/SSLContext.java line 354:
>> 
>>> 352:      *
>>> 353:      * @implNote
>>> 354:      * It is provider-specific if the returned SSLEngine uses client or
>> 
>> I think I'd keep the "It is provider-specific" sentence, though I'm not sure 
>> if it belongs in the implNote.
>
> Agreed, but as written, it implies that there is always a default, which is 
> not the case for the SunJSSE provider. So I think it would need to be 
> reworded like: "It is provider-specific if the returned SSLEngine uses client 
> or server mode by default for the (D)TLS connection, or requires the mode to 
> be set."

Yes, I removed "It is provider-specific" sentence because it doesn't seem to 
belong to implNote. I'll put the wording Sean has suggested in a separate 
paragraph above the implNote.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30754#discussion_r3093731089

Reply via email to