On Thu, 9 Apr 2026 21:38:21 GMT, Mikhail Yankelevich <[email protected]> wrote:
>> Cleanup test/jdk/sun/security/provider/SecureRandom/StrongSecureRandom.java >> and convert to junit >> >> No logic changes, just refactored to junit for easier debug and clearer >> detection of skipped/kept sections >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > minor test/jdk/sun/security/provider/SecureRandom/StrongSecureRandom.java line 130: > 128: public void testUnsupportedParams(final String alg) { > 129: // 'assuming' in order to skip the test if needed > 130: assumeFalse(os.startsWith("Windows"), "Skip Windows testing"); It's not really part of the changeset but a pretty standard convention is that final variables/fields are uppercase. For a variable as short (and small) as "os", it also helps to just read it in the code. test/jdk/sun/security/provider/SecureRandom/StrongSecureRandom.java line 206: > 204: */ > 205: @Test > 206: public void testAllImpls() throws Exception { The comment on this method says it's duplicating "stuff above". If something is duplicated why not just remove the duplication? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30655#discussion_r3124724338 PR Review Comment: https://git.openjdk.org/jdk/pull/30655#discussion_r3124715626
