On Wed, 22 Apr 2026 14:34:33 GMT, Matthew Donovan <[email protected]> wrote:
>> Mikhail Yankelevich has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> minor
>
> test/jdk/sun/security/provider/SecureRandom/StrongSecureRandom.java line 130:
>
>> 128: public void testUnsupportedParams(final String alg) {
>> 129: // 'assuming' in order to skip the test if needed
>> 130: assumeFalse(os.startsWith("Windows"), "Skip Windows testing");
>
> It's not really part of the changeset but a pretty standard convention is
> that final variables/fields are uppercase. For a variable as short (and
> small) as "os", it also helps to just read it in the code.
Yeah, I agree, will change
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30655#discussion_r3125340835
