On Wed, 22 Apr 2026 14:33:10 GMT, Matthew Donovan <[email protected]> wrote:
>> Mikhail Yankelevich has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> minor
>
> test/jdk/sun/security/provider/SecureRandom/StrongSecureRandom.java line 206:
>
>> 204: */
>> 205: @Test
>> 206: public void testAllImpls() throws Exception {
>
> The comment on this method says it's duplicating "stuff above". If something
> is duplicated why not just remove the duplication?
My understanding of the comment is that some algorithms would be present in
this test and in previous due to the `getAlgorithms` being called. I think this
comment was left to warn that this is intentional, that's why I didn't change
it.
Do you want me to keep it or change it?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30655#discussion_r3125361642
