On Thu, 23 Apr 2026 16:57:55 GMT, Kieran Farrell <[email protected]> wrote:

>> src/java.security.jgss/share/classes/sun/security/krb5/Config.java line 1391:
>> 
>>> 1389:         String kdcs = "";
>>> 1390:         String[] srvs = null;
>>> 1391:         NamingException udpNE = null;
>> 
>> I think this might be a bit hard to read, what do you think about making the 
>> name longer like `udpNamingException` so it's clear at a glance? 
>> If you prefer as is i'm fine with it
>
> Thanks @myankelev, happy to follow up on these, however I was about to update 
> the PR to a simple debug log output and remove the tests for simplicity, any 
> objections/thoughts?

The solution is fine, but removing tests would depend on whether the code will 
end up already having coverage. I'd say go for it and lets see if there is a 
need for new tests :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30824#discussion_r3136505816

Reply via email to