On Fri, 24 Apr 2026 14:44:14 GMT, Kieran Farrell <[email protected]> wrote:

>> In DNS-based KDC discovery failures are exposed as generic 'KrbException: 
>> Cannot locate KDC / Unable to locate KDC for realm <REALM>' with no 
>> indication whether the underlying DNS SRV lookup failed due to NXDOMAIN, 
>> SERVFAIL, or a communication timeout.
>> 
>> To improve supportability, this patch updates 
>> `KrbServiceLocator.getKerberosService(realm, protocol)` to rethrow the 
>> original JNDI NamingException from the SRV lookup and attach a sanitized 
>> failure category to the existing KrbException when both udp and tcp 
>> discovery attempts fail, while preserving the original top level exception 
>> message. `Config.getKDCFromDNS()` is updated to catch exception, sanitize it 
>> into the relevant category to prevent leaking any senistive information and 
>> attach it to the existing KrbException.
>> 
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Kieran Farrell has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   restore krb exception comment

Isn't simpler to just uncomment the existing `e.printStackTrace()` that was 
commented out inside the `getKerberosService(r,p)` method and put it into a `if 
DEBUG` block?

Also, you can do the same for the other `getKerberosService(s)` method as well.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/30824#issuecomment-4314113918

Reply via email to