On Mon, 27 Apr 2026 16:16:15 GMT, Mikhail Yankelevich <[email protected]> wrote:
>> * fully automated the test >> * removed the race condition >> * client on a thread and server on a thread options are now run together >> automatically >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Mikhail Yankelevich has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains eight additional > commits since the last revision: > > - comments > - Merge branch 'master' into JDK-8249824 > - addressing comments > - Merge branch 'master' into JDK-8249824 > - cleanup and update of the code to the current style > - minor comment changes > - Apply suggestions from cr > > Co-authored-by: Daniel Fuchs <[email protected]> > - JDK-8249824: s/n/w/p/https/HttpsURLConnection/CloseKeepAliveCached.java > uses @ignore w/o bugid > > * fully automated the test > * removed the race condition > * client on a thread and server on a thread options are now run together > automatically test/jdk/sun/net/www/protocol/https/HttpsURLConnection/CloseKeepAliveCached.java line 102: > 100: * Is the server ready to serve? > 101: */ > 102: volatile static CountDownLatch serverReady = new CountDownLatch(1); Looks like this could be final rather than volatile. test/jdk/sun/net/www/protocol/https/HttpsURLConnection/CloseKeepAliveCached.java line 104: > 102: volatile static CountDownLatch serverReady = new CountDownLatch(1); > 103: > 104: private SSLServerSocket sslServerSocket = null; sslServerSocket is set by one thread and read by the other so it should be volatile. test/jdk/sun/net/www/protocol/https/HttpsURLConnection/CloseKeepAliveCached.java line 111: > 109: * If the server prematurely exits, serverReady will be set to true > 110: * to avoid infinite hangs. > 111: */ serverReady is now a CountDownLatch. Does the comment still apply? I guess that that if doServerSide fails because e.g. server socket creation fails then the client side waits forever and the test fails in jtreg timeout? Is that the desired behaviour (It's OK if it is)? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23469#discussion_r3148944040 PR Review Comment: https://git.openjdk.org/jdk/pull/23469#discussion_r3148982556 PR Review Comment: https://git.openjdk.org/jdk/pull/23469#discussion_r3148928925
