On Mon, 27 Apr 2026 16:56:27 GMT, Daniel Fuchs <[email protected]> wrote:
>> Mikhail Yankelevich has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains eight >> additional commits since the last revision: >> >> - comments >> - Merge branch 'master' into JDK-8249824 >> - addressing comments >> - Merge branch 'master' into JDK-8249824 >> - cleanup and update of the code to the current style >> - minor comment changes >> - Apply suggestions from cr >> >> Co-authored-by: Daniel Fuchs <[email protected]> >> - JDK-8249824: s/n/w/p/https/HttpsURLConnection/CloseKeepAliveCached.java >> uses @ignore w/o bugid >> >> * fully automated the test >> * removed the race condition >> * client on a thread and server on a thread options are now run together >> automatically > > test/jdk/sun/net/www/protocol/https/HttpsURLConnection/CloseKeepAliveCached.java > line 111: > >> 109: * If the server prematurely exits, serverReady will be set to true >> 110: * to avoid infinite hangs. >> 111: */ > > serverReady is now a CountDownLatch. Does the comment still apply? I guess > that that if doServerSide fails because e.g. server socket creation fails > then the client side waits forever and the test fails in jtreg timeout? Is > that the desired behaviour (It's OK if it is)? I'd say it would be expected behaviour since this should not happen anyway. I will remove the comment ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23469#discussion_r3153586898
