On Wed, 22 Apr 2026 08:32:15 GMT, Michael McMahon <[email protected]> wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add `ofString` static factory method > > src/java.base/share/classes/javax/net/ssl/SNIHostName.java line 83: > >> 81: * <li>It ends with a trailing dot >> 82: * <li>It is not a valid Internationalized Domain Name (IDN)</li> >> 83: * > > This list seems to imply that an SNI hostname must be an IDN. I wonder if it > might be better to first state what a valid SNI hostname is (ie a DNS > hostname), mentioning IDNs and then later specify the exclusions, including > (I presume) a string that starts with "xn--" but which doesn't represent a > valid IDN? I see your point, a valid one. In 9596a5b2ca0, I've massaged the opening paragraphs to start with explaining what constitutes a valid SNI hostname. Following that, I've stated exclusions, shared examples, and had a dedicate section on DNS hostname validation. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30747#discussion_r3153688017
