On Wed, 22 Apr 2026 06:50:24 GMT, Alan Bateman <[email protected]> wrote:
>> I'm glad you said this, I completely agree with your concern and reasoning. >> I will do it. >> >> Though this reminded me another question I need some help with: Shall I >> migrate existing usages of `SNIHostName::new` to the new static factory >> methods in this PR? Slim PRs are ideal, but leaving the correction of >> call-sites to a 2nd PR bears the risk that we might end up having a 3rd PR >> if the 1st (this) one has any problems. > > There may be compatibility issues with change the existing usages (as they > might fail with IAE) so I would keep that separate. In 9596a5b2ca0, I've deprecated constructors and sprinkled `@apiNote` and `@deprecated` to direct users to the new static factory methods. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30747#discussion_r3153696304
