On Tue, 28 Apr 2026 16:48:48 GMT, Daniel Fuchs <[email protected]> wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Big facelift
>
> src/java.net.http/share/classes/jdk/internal/net/http/AbstractAsyncSSLConnection.java
> line 179:
>
>> 177: if (name != null && !name.isEmpty()) {
>> 178: @SuppressWarnings("deprecation")
>> 179: var sni = new SNIHostName(name);
>
> Is there any chance that the new factory method would throw when called from
> here? If not we might as well call it?
I was told by @AlanBateman in [this conversation] to carry out the migration to
the new methods in a separate PR.
[this conversation]:
https://github.com/openjdk/jdk/pull/30747#discussion_r3122066569
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30747#discussion_r3166518709
