On Thu, 30 Apr 2026 08:13:28 GMT, Volkan Yazici <[email protected]> wrote:

>> src/java.net.http/share/classes/jdk/internal/net/http/AbstractAsyncSSLConnection.java
>>  line 179:
>> 
>>> 177:             if (name != null && !name.isEmpty()) {
>>> 178:                 @SuppressWarnings("deprecation")
>>> 179:                 var sni = new SNIHostName(name);
>> 
>> Is there any chance that the new factory method would throw when called from 
>> here? If not we might as well call it?
>
> I was told by @AlanBateman in [this conversation] to carry out the migration 
> to the new methods in a separate PR.
> 
> [this conversation]: 
> https://github.com/openjdk/jdk/pull/30747#discussion_r3122066569

The suggestion to do the migrations in separate PRs was to allow the 
compatibility impact of each be studied. Up to you if you want to include 
some/all at the same time.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30747#discussion_r3166537366

Reply via email to