On Thu, 30 Apr 2026 17:25:01 GMT, Weijun Wang <[email protected]> wrote:
>> Artur Barashev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits since the last revision: >> >> - Add @throws section to getUseClientMode() >> - Merge branch 'master' into JDK-8382270 >> - Throw an exception when getUseClientMode() is called before >> setUseClientMode(). Remove any notion of default from SSLEngine javadoc >> - Address review comments >> - 8382270: Update SSLContex API javadoc: require setUseClientMode call for >> SunJSSE > > src/java.base/share/classes/javax/net/ssl/SSLEngine.java line 1142: > >> 1140: * handshaking. >> 1141: * <P> >> 1142: * This method must be called before any handshaking occurs. > > This is not a "must". Either "should" or "is recommended". It is a `must` in case of JSSE, otherwise we throw an exception. But this is a good point, I think we should place this text under `@implNote` ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30754#discussion_r3169890678
