On Thu, 30 Apr 2026 17:26:37 GMT, Weijun Wang <[email protected]> wrote:
>> Artur Barashev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits since the last revision:
>>
>> - Add @throws section to getUseClientMode()
>> - Merge branch 'master' into JDK-8382270
>> - Throw an exception when getUseClientMode() is called before
>> setUseClientMode(). Remove any notion of default from SSLEngine javadoc
>> - Address review comments
>> - 8382270: Update SSLContex API javadoc: require setUseClientMode call for
>> SunJSSE
>
> src/java.base/share/classes/javax/net/ssl/SSLContext.java line 361:
>
>> 359: * be set explicitly by calling
>> 360: * {@link SSLEngine#setUseClientMode(boolean)
>> SSLEngine.setUseClientMode()}
>> 361: * before invoking other methods of the SSLEngine.
>
> Is it all "other methods"?
Not really all other methods, but I think it's safe to keep the wording as is.
We don't know what methods will require a mode to be set in the future.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30754#discussion_r3170057121
