On Tue, 18 Aug 2026 09:09:57 GMT, Andrew Haley <[email protected]> wrote:
>> Shawn Emery has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Implement comments from theRealAph and adinn
>
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 5134:
>
>> 5132: if (can_use_r18 && can_use_fp) {
>> 5133: __ str(r18_tls, Address(sp, 96));
>> 5134: }
>
> This needs refactoring.
> Suggestion:
>
> auto saved_regs = RegSet::range(r19, r28) + state0 + state1;
> if (can_use_r18 && can_use_fp) {
> saved_regs += r18_tls;
> }
> __ push(saved_regs, sp);
Good suggestion. Done! Do you want me to add you as a co-author?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32049#discussion_r3810364952
