On Wed, 19 Aug 2026 05:47:09 GMT, Shawn Emery <[email protected]> wrote:
>> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 5134:
>>
>>> 5132: if (can_use_r18 && can_use_fp) {
>>> 5133: __ str(r18_tls, Address(sp, 96));
>>> 5134: }
>>
>> This needs refactoring.
>> Suggestion:
>>
>> auto saved_regs = RegSet::range(r19, r28) + state0 + state1;
>> if (can_use_r18 && can_use_fp) {
>> saved_regs += r18_tls;
>> }
>> __ push(saved_regs, sp);
>
> Good suggestion. Done! Do you want me to add you as a co-author?
I don't mind.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32049#discussion_r3811717665
