On Wed, 16 Sep 2026 15:23:08 GMT, Artur Barashev <[email protected]> wrote:
>> Hai-May Chao has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Tests update with Artur's comments
>> - Revert change to TLSCurveMismatch.java
>> - Revert change to CertificateMessage.java
>
> test/jdk/sun/security/ssl/SignatureScheme/MLDSACertSignSchemeConstraint.java
> line 142:
>
>> 140: if (expectFail) {
>> 141: throw new RuntimeException(
>> 142: "Expected SSLHandshakeException was not
>> thrown");
>
> s/SSLHandshakeException/SSLException/
Done.
> test/jdk/sun/security/ssl/SignatureScheme/MLDSAClientAuthMismatch.java line
> 67:
>
>> 65:
>> 66: private static final String TEST_CASE =
>> System.getProperty("test.case");
>> 67:
>
> Suggestion:
>
> private MLDSAClientAuthMismatch() {
> super(true); // server on separate thread, client on current thread
> }
Done.
> test/jdk/sun/security/ssl/SignatureScheme/MLDSAClientAuthMismatch.java line
> 141:
>
>> 139: }
>> 140:
>> 141: assertEquals(e.getMessage(), "(internal_error) Received " +
>
> Check the client’s underlying error:
>
> Suggestion:
>
> assertEquals(e.getMessage(), "(internal_error) No supported "
> + "CertificateVerify signature algorithm for ML-DSA key");
Updated to check for client's exception.
> test/jdk/sun/security/ssl/SignatureScheme/MLDSANotAllowedInTLS12.java line 37:
>
>> 35: import java.util.List;
>> 36:
>> 37: public class MLDSANotAllowedInTLS12 extends
>> AbstractCheckSignatureSchemes {
>
> It would be useful to also have a positive test for TLSv1.3. Such test can be
> extended from this class: we'll override `getProtocol()` and use
> `assertMldsa()` instead of `assertNoMldsa()`; `checkCertificateRequest()` can
> be overriden with an empty method since CertificateRequest message is
> encrypted in TLSv1.3.
Added a positive test `MLDSAAllowedInTLS13.java`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32529#discussion_r4030083404
PR Review Comment: https://git.openjdk.org/jdk/pull/32529#discussion_r4030082543
PR Review Comment: https://git.openjdk.org/jdk/pull/32529#discussion_r4030082662
PR Review Comment: https://git.openjdk.org/jdk/pull/32529#discussion_r4030083773
