On Wed, 16 Sep 2026 20:38:23 GMT, Artur Barashev <[email protected]> wrote:
>> Hai-May Chao has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Renamed test MLDSACertSignSchemeConstraint.java to >> MLDSASigSchemeConstraints.java >> - Updated tests with Artur's comments > > test/jdk/sun/security/ssl/SignatureScheme/MLDSANotAllowedInTLS12.java line 27: > >> 25: * @test >> 26: * @bug 8381641 >> 27: * @summary Test ML-DSA signature scheme advertisement in TLS 1.2 and >> TLS 1.3 > > Nit: this class tests only TLS 1.2 Removed TLS 1.3. > test/jdk/sun/security/ssl/SignatureScheme/MLDSANotAllowedInTLS12.java line > 109: > >> 107: } >> 108: >> 109: protected static void assertMldsa(List<String> signatureSchemes, > > Let's verify not only the presence but the order here: the input list should > start with `"mldsa65", "mldsa87", "mldsa44"`. Added mldsa order check. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32529#discussion_r4030965740 PR Review Comment: https://git.openjdk.org/jdk/pull/32529#discussion_r4030965907
