On Thu, 29 Oct 2026 20:45:25 GMT, Weijun Wang <[email protected]> wrote:
> Four major comments: > > 1. I don't understand what those `getXyzProvider` methods in `NamedGroup` > are for. > > 2. You can keep the `HybridProvider` class and put `KEM.DH` there, then > there is no need for those adapter records or classical flags. > > 3. Now that we don't require hybrid `KeyFactory`, there is no need to > implement `KeyFactoryImpl` in `Hybrid.java`. Just provide a `PublicKeyImpl` > constructor on byte array seems enough. > > 4. There are cases where one or both of the shared secret keys cannot be > extracted and you cannot get the RAW concatenated secret. This is the > ultimate reason we design the multi-step `addIKM` methods in > `HKDFParameterSpec`. Please restore the two-step `addIKM` codes. > `SecretKeyImpl::getEncoded` can return null since it will not used here. Agree. Changes made to address these comments. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk/pull/33433#issuecomment-6517429499
