On Fri, 30 Oct 2026 12:47:12 GMT, Weijun Wang <[email protected]> wrote:

> Thanks for the quick changes. Mostly resolved except for 2 small issues. I've 
> added comment above.
> 
> There is another issue with the new hybrid `KeyPairGenerator`. First, only 
> `initialize` set params to both left and right, which means if `initialize` 
> is not called, SecP256r1MLKEM768's left is not explicitly initialized and it 
> will generate a secp384r1 key pair. Second, `initialize` completely ignores 
> the input params. I know our documentation is quite clear that it should not 
> be used as a general-purpose algorithm, but it does not prevent people using 
> it in other protocols similar to TLS where the transcript protection is 
> available.

Addressed. Thank you.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/33433#issuecomment-6543009135

Reply via email to