On Fri, 30 Oct 2026 08:05:56 GMT, Hai-May Chao <[email protected]> wrote:

>> This feature enables SunJSSE to use a TLS 1.3 hybrid named group implemented 
>> directly by a security provider as JCA `KeyPairGenerator` and `KEM` 
>> services. It also moves the JDK implementations of `X25519MLKEM768`, 
>> SecP256r1MLKEM768, and `SecP384r1MLKEM1024` into SunJCE provider.
>> 
>> ---------
>> - [X] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Hai-May Chao has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Remove unused adapter from DHasKEM

Thanks for the quick changes. Mostly resolved except for 2 small issues. I've 
added comment above.

There is another issue with the new hybrid `KeyPairGenerator`. First, only 
`initialize` set params to both left and right, which means if `initialize` is 
not called, SecP256r1MLKEM768's left is not explicitly initialized and it will 
generate a secp384r1 key pair. Second, `initialize` completely ignore the input 
params. I know our documentation is quite clear that it should not be used as a 
general-purpose algorithm, but it does not prevent people using it in other 
protocols similar to TLS where the transcript protection is available.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/33433#issuecomment-6523196741

Reply via email to