[ https://issues.apache.org/jira/browse/JAMES-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979510#action_12979510 ]
Eric Charles commented on JAMES-1181: ------------------------------------- Hi Stefano, For the record, there is a module dependency view (not updated, it's moving too fast for now) in https://svn.apache.org/repos/asf/james/server/trunk/src/site/resources/model-eclipse-modeler/ It's done with eclipse modeler and it's goal was to show the server module dependencies towards imap, mailbox, protocols. Is your graph automatically generated ? Which tool did you use ? (maybe we could use the same have have it in svn so anyone can let it evolve) - yes, picture, especially with colors, tell more than words :) About the util dnservice-api dep, we moved the netmatcher to util, cause it was not worth a module. However, I fear about moving netmatcher to core, cause it will make core the default place for all stuff not having a real place. but I don't have other proposal to give you.. > Modules dependencies review > --------------------------- > > Key: JAMES-1181 > URL: https://issues.apache.org/jira/browse/JAMES-1181 > Project: JAMES Server > Issue Type: Task > Components: Build System > Affects Versions: 3.0-M2 > Reporter: Stefano Bagnara > Priority: Minor > Attachments: graph-server-check.gif > > > Just opening an issue because it's simpler to share the image. This can even > be closed as won't fix or resolved. > I found some time to checkout and take some review the current trunk, > starting from modules dependencies. > I have to say the code seems better organized than some months ago, but the > layers increased. This is not necessarily bad, but I think it worth noticing > this. > On past we simply had 3 layers (api, library, function) with clear dependency > scheme: libraries depending only on api, api having no dependencies, > functions depending on api or libraries. > Now I tried to create an updated scheme and things are a bit more complicated > now. > E.g: > util depends on dnsservice-api > core depends on util > mailetcontainer-library depends on core > So in this case between library and api we have 2 more layers. > I didn't investigate on the real classes creating this dependencies issues, > so I don't know how feasible is to fix this "layering" and if it worth or not. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org