[ 
https://issues.apache.org/jira/browse/JAMES-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979658#action_12979658
 ] 

Norman Maurer commented on JAMES-1181:
--------------------------------------

After a quick review it looks better from the dependency tree. Anyway It seems 
kind of "odd" to have these classes which not depend on any Camel class in the 
mailetcontainer-camel module, but maybe its just me ;)

About the nio-netty rename... what about protocols-library ?


> Modules dependencies review
> ---------------------------
>
>                 Key: JAMES-1181
>                 URL: https://issues.apache.org/jira/browse/JAMES-1181
>             Project: JAMES Server
>          Issue Type: Task
>          Components: Build System
>    Affects Versions: 3.0-M2
>            Reporter: Stefano Bagnara
>            Priority: Minor
>         Attachments: graph-server-check.gif, graph-server-edited.gif
>
>
> Just opening an issue because it's simpler to share the image. This can even 
> be closed as won't fix or resolved.
> I found some time to checkout and take some review the current trunk, 
> starting from modules dependencies.
> I have to say the code seems better organized than some months ago, but the 
> layers increased. This is not necessarily bad, but I think it worth noticing 
> this.
> On past we simply had 3 layers (api, library, function) with clear dependency 
> scheme: libraries depending only on api, api having no dependencies, 
> functions depending on api or libraries.
> Now I tried to create an updated scheme and things are a bit more complicated 
> now.
> E.g:
> util depends on dnsservice-api
> core depends on util
> mailetcontainer-library depends on core
> So in this case between library and api we have 2 more layers.
> I didn't investigate on the real classes creating this dependencies issues, 
> so I don't know how feasible is to fix this "layering" and if it worth or not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

Reply via email to