Hi Gazda,
Looking at the diffs in the order as there are shown on [1]:
API
1.- profile noTest on mailbox-integration-tester: ok
2.- LocalAndVirtualMailboxLocatorChain: what's the goal?
3.- MailboxPath is now MailboxName: Path sounded more like
folder/subfolder/subfolder.
4.- MailboxNameResolver on MailboxManager
5.- MailboxSession has no more PersonalSpace nor UserSpace but a
MailboxOwner.
6. SubscriptionManager now works with MailboxName and no more with
String for mailboxname; OK
7. MailboxACL and MailboxACLCodec: already there before I think
8. mmh, MailboxPath is still there.
9. MailboxNameSerializer, MailboxNameBuilder, MailboxNameCodec,
MailboxNamespaceType, MailNameEscaper
10. LikeSearchPatternEscaper: why deal with JCR, SQL in the API?
11. More and more unit tests... :)
JCR, JPA and MEMORY Modules
12. I guess this is the impact of the API changes.
HBASE
13. Didn't see any change in the diff
SPRING
14. I guess this is the impact of the API changes.
STORE
14. I guess this is the impact of the API changes.
PROTOCOLS IMAP
15. Sounds logic imap is the only impacted module
So very very impressive changes. May I summary them as more typing for
domains that ease the reading and implementation of ACL and the overall
mailbox?
To be honest, I didn't see well if and how the ACL are applied... :)
It would be great if you could answer with a few lines presenting the
reasoning behind those changes.
And welcome to git + good start for your new job.
Thx, Eric
[1]
https://github.com/gazdahimself/current/commit/ae75a54400bc7aa93763657a48596d09ec357f98,
On 06/27/2012 06:55 PM, Jochen Gazda wrote:
Gentlemen,
I have finally managed it to publish my changeset on GitHub:
https://github.com/gazdahimself/current/tree/MAILBOX-175
The state of my brach MAILBOX-175 is in sync with the currently latest
svn revision 1354581. My brach MAILBOX-175 can also be diffed against
svn revision 1354581 directly on GitHub.
Sorry for the delay, I am new to git and I have a new job.
Please comment.
Best,
gazda
On Wed, Jun 13, 2012 at 1:51 PM, Ioan Eugen Stan<[email protected]> wrote:
HI Gazda,
Git is great.
Cheers,
2012/6/13 Eric Charles<[email protected]>:
Hi Gazda,
I'm fine with the push to your personal github. It offers nice ui to show
diffs.
Thx, Eric
On 06/13/2012 10:32 AM, Jochen Gazda wrote:
Gentlemen,
I could invest about 6 weeks of my time into solving
https://issues.apache.org/jira/browse/MAILBOX-175 and
https://issues.apache.org/jira/browse/MAILBOX-167.
The result is quite a huge and deep changeset. There is a de facto
replacement for MailboxPath - so you can imagine, how many classes
were changed.
Before going too much into details I wanted to agree on a way how my
changeset could find its way into SVN.
The changes should be discussed before they are committed to trunk.
But I am not sure what is the best way to share my changes before they
are committed to trunk.
Would cloning from http://git.apache.org/ and pushing changes to my
personal GitHub repo be a viable solution?
I am also ready to send my zipped workspace (~30MB) to anybody who
wants to have a quick look.
Best,
gazda
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
--
eric | http://about.echarles.net | @echarles
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
--
Ioan Eugen Stan / http://axemblr.com / Tools for Clouds
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
--
eric | http://about.echarles.net | @echarles
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
