On 29.12.2014 16:51, Claes Redestad wrote:
Hi,
some classes in jvmstat/perfdata code contains debug logging code
predating the logging APIs, which
provokes some unnecessary allocation in certain applications.
Since the debug logging can't have been used for quite some time, I
propose to remove it altogether
rather than converting it to the j.u.l. framework.
While it's good to see the dead code gone I would prefer keeping the
logging code just commented out - the logging code could be useful when
investigating any future failures.
Converting to j.u.l. wouldn't probably completely remove the unnecessary
allocation (due to object arrays for varargs) unless you guard each log
call for the required logging level.
-JB-
bug: https://bugs.openjdk.java.net/browse/JDK-8028357
webrev: http://cr.openjdk.java.net/~redestad/8028357/webrev.01/
/Claes
