On 30.12.2014 23:22, Claes Redestad wrote:
On 2014-12-30 18:35, Jaroslav Bachorik wrote:
The affected files are pretty stable so we could remove *all* the
logging related methods. When a necessity arises to have a
configurable logging we would just need to re-introduce it properly.
Right, I'll leave the patch as-is when it comes to code changes.
This got me thinking - a comment warning about the possible
performance issues when adding logging could be added as a courtesy to
the later maintainers.
If so, what should we write? I'm not sure we really need to be this
cautious in this particular code, and I hope future maintainers will
care about performance at least as much as we are without well-meaning
warnings.
Well, it might take time till they realize this code is performance
sensitive (it took us some time :) So, why not to make it easier for the
future ourselves?
I guess something like "// 8028357 removed old, inefficient debug
logging" in place of the DEBUG declaration in each affected file
wouldn't be too busy and also give future maintainers a handle to this
changeset and thus this discussion. Would that suffice?
Sounds good.
Please, update the copyright years in the affected files before push.
Reviewed.
-JB-
/Claes
-JB-
