Hi Christoph, thanks for doing this laborious change ... comparing all these files :)
Change looks good, just some minor comments: You say you are sorting the includes, but in the VirtualMachineImpl.c files the order is changed, but according to which order? It's not alphabetical as in other files. In windows VirtualMachineImpl.c, what was wrong with printing the last error code? Best regards, Goetz. > -----Original Message----- > From: serviceability-dev [mailto:serviceability-dev- > boun...@openjdk.java.net] On Behalf Of Langer, Christoph > Sent: Freitag, 6. April 2018 17:02 > To: serviceability-dev@openjdk.java.net > Cc: hotspot-...@openjdk.java.net > Subject: [CAUTION] RFR (M): 8201247: Various cleanups in the attach > framework > > Hi, > > > > can I please get reviews for a set of clean up changes that I came across > when doing some integration work. > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8201247 > <https://bugs.openjdk.java.net/browse/JDK-8201247> > > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8201247.0/ > <http://cr.openjdk.java.net/~clanger/webrevs/8201247.0/> > > > > Detailed comments about the changes can be found in the bug. > > > > Thanks & best regards > > Christoph > > > >
