Hi Patricio,
Thanks for looking at this.
On 4/03/2021 5:26 am, Patricio Chilano Mateo wrote:
Hi David,
Changes look good to me.
Thanks,
Patricio
src/hotspot/share/runtime/objectMonitor.hpp line 306:
304:
305: bool enter(JavaThread* current);
306: void exit(bool not_suspended, TRAPS);
Shouldn't we also remove use of TRAPS for exit()? In case of unbalanced locking
we don't throw IMSE, only just assert.
Good catch! (no pun intended). Yes I overlooked that was don't actually
throw the IMSE in plain exit (in contrast to jni_exit).
Fixed.
Thanks,
David
-----
-------------
Marked as reviewed by pchilanomate (Committer).
PR: https://git.openjdk.java.net/jdk/pull/2802
