On Wed, 31 Mar 2021 03:59:35 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Robbin Ehn has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains two commits: >> >> - Merge branch 'master' into SuspendInHandshake >> - 8257831: Suspend with handshake (review baseline) > > src/hotspot/share/prims/jvmtiRawMonitor.cpp line 319: > >> 317: jt = self->as_Java_thread(); >> 318: while (true) { >> 319: // To pause suspend requests while in native we must block >> handshakes. > > The earlier comment says we must be _thread_blocked in this code, so we won't > be "native". But that is not a _thread_blocked that is managed by a > thread-state transition so that is why this code has to "manually" manage the > handshake state. Fixed comment ------------- PR: https://git.openjdk.java.net/jdk/pull/3191