On Sat, 18 Sep 2021 21:35:41 GMT, Andrey Turbanov <github.com+741251+turban...@openjdk.org> wrote:
> There are few places in code where manual while loop is used with Iterator to > iterate over Collection. > Instead of manual while cycles it's preferred to use enhanced-for cycle > instead: it's less verbose, makes code easier to read and it's less > error-prone. > It doesn't have any performance impact: java compiler generates similar code > when compiling enhanced-for cycle. > > Similar cleanups: > * https://bugs.openjdk.java.net/browse/JDK-8258006 > * https://bugs.openjdk.java.net/browse/JDK-8257912 src/jdk.jdi/share/classes/com/sun/tools/jdi/EventRequestManagerImpl.java line 881: > 879: // copy the eventRequests to avoid > ConcurrentModificationException > 880: for (EventRequest eventRequest : new ArrayList<>(eventRequests)) > { > 881: ((EventRequestImpl) eventRequest).delete(); I'm not sure the `eventRequest` needs to be wrapped into new `ArrayList`. I think, this should work without it. ------------- PR: https://git.openjdk.java.net/jdk/pull/5577
