> There are few places in code where manual while loop is used with Iterator to > iterate over Collection. > Instead of manual while cycles it's preferred to use enhanced-for cycle > instead: it's less verbose, makes code easier to read and it's less > error-prone. > It doesn't have any performance impact: java compiler generates similar code > when compiling enhanced-for cycle. > > Similar cleanups: > * https://bugs.openjdk.java.net/browse/JDK-8258006 > * https://bugs.openjdk.java.net/browse/JDK-8257912
Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: 8274755: Replace 'while' cycles with iterator with enhanced-for in jdk.jdi remove empty space before casts in InvokableTypeImpl too ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/5577/files - new: https://git.openjdk.java.net/jdk/pull/5577/files/1de15c21..669f2a31 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5577&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5577&range=01-02 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk/pull/5577.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5577/head:pull/5577 PR: https://git.openjdk.java.net/jdk/pull/5577