On Wed, 6 Oct 2021 19:00:35 GMT, Andrey Turbanov <github.com+741251+turban...@openjdk.org> wrote:
>> There are few places in code where manual while loop is used with Iterator >> to iterate over Collection. >> Instead of manual while cycles it's preferred to use enhanced-for cycle >> instead: it's less verbose, makes code easier to read and it's less >> error-prone. >> It doesn't have any performance impact: java compiler generates similar code >> when compiling enhanced-for cycle. >> >> Similar cleanups: >> * https://bugs.openjdk.java.net/browse/JDK-8258006 >> * https://bugs.openjdk.java.net/browse/JDK-8257912 > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > 8274755: Replace 'while' cycles with iterator with enhanced-for in jdk.jdi > remove empty space before casts in InvokableTypeImpl too I also was going to comment on the space after each cast, but then I went in search of an openjdk java style guide and found this: http://cr.openjdk.java.net/~alundblad/styleguide/index-v6.html Which says to use a single space "After the closing parenthesis of a cast". Personally I don't like it, and I don't know if this is an official guide, but it's the only openjdk style guide I could find. I did also find the following, which says the same, but is not specifically for openjdk: https://google.github.io/styleguide/javaguide.html#s4.6-whitespace ------------- PR: https://git.openjdk.java.net/jdk/pull/5577
