On Tue, 30 Nov 2021 11:26:04 GMT, Andrew Haley <a...@openjdk.org> wrote:
>> Aleksey Shipilev has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
>> commits since the last revision:
>>
>> - Merge branch 'master' into JDK-8274903-zero-asyncgetcalltrace
>> - Fix a comment
>> - Merge branch 'master' into JDK-8274903-zero-asyncgetcalltrace
>> - More reviews
>> - Review feedback
>> - Merge branch 'master' into JDK-8274903-zero-asyncgetcalltrace
>> - Initial work: runs async-profiler successfully
>
> src/hotspot/cpu/zero/frame_zero.cpp line 139:
>
>> 137: assert(is_interpreted_frame(), "Not an interpreted frame");
>> 138: // These are reasonable sanity checks
>> 139: if (fp() == 0 || (intptr_t(fp()) & (wordSize-1)) != 0) {
>
> Use `is_aligned()` here?
@theRealAph Do you agree with above? Any more comments?
-------------
PR: https://git.openjdk.java.net/jdk/pull/5848
