On Wed, 26 Jan 2022 05:39:43 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
> The changes look good except I haven't look at the new test that closely. It > really could use a high level explanation of how the test works, plus some > embedded comments. Too much to figure out by just looking at the code. Also, > is there an existing test it was based on? Seems like a lot of code just for > testing of a single attribute. Many tests in test/jdk/java/lang/instrument are similar - they extends ATransformerManagementTestCase, but this are regression tests for specific bugs. I think it's better to have simple testcase for this issue too. ------------- PR: https://git.openjdk.java.net/jdk/pull/7180
