On Thu, 27 Jan 2022 04:23:51 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Simplified the test, added comments > > src/hotspot/share/prims/jvmtiRedefineClasses.cpp line 3692: > >> 3690: elem[j].name_cp_index = new_cp_index; >> 3691: } >> 3692: } > > Indentation should be 2, not 4. Fixed. Also added explicit cast int -> u2 > test/jdk/java/lang/instrument/RetransformWithMethodParametersTest.java line > 54: > >> 52: * correctly handles MethodParameter attribute: >> 53: * - classfile bytes passed to transformers (and JVMTI ClassFileLoadHook >> event callback) contain the attribute; >> 54: * - the attribute is updated. > > I think you could use a bit more than this. Basically summarize the 3 test > cases in doRunTests(). Done. ------------- PR: https://git.openjdk.java.net/jdk/pull/7180
